Add tests for DurationFormat PR 172 and 167#3912
Merged
Conversation
FrankYFTang
force-pushed
the
DurationFormatOrder
branch
from
0073051 to
0ef5242
Compare
anba
approved these changes
Jan 10, 2024
Contributor
anba
left a comment
anba
left a comment
There was a problem hiding this comment.
Tests pass with an implementation of the latest spec draft.
assert.compareArray could be used instead of assert.sameValue, but that's not a blocker preventing to land this PR.
FrankYFTang
force-pushed
the
DurationFormatOrder
branch
from
f9787c6 to
5934738
Compare
FrankYFTang
force-pushed
the
DurationFormatOrder
branch
from
5934738 to
1ed8220
Compare
Contributor
Author
|
ping |
ptomato
approved these changes
Jul 11, 2024
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Thanks, seems correct but it seems like there's a couple of opportunities to cover more observable effects of the PRs. Can be done in a followup if necessary.
Contributor
|
@FrankYFTang Do you want to address the above comments or postpone them to a followup? |
Contributor
Author
I will address that later |
Test the order of resolvedOptions in default setting Also add test to check the reading order of options based on the property returned in the default setting resolvedOptions. tc39/proposal-intl-duration-format#167 tc39/proposal-intl-duration-format#172 https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat.prototype.resolvedOptions These two PRs are presenting to TC39 2023-09 meeting Swap actual/expected order Update test/intl402/DurationFormat/constructor-option-read-order.js Co-authored-by: André Bargull <andre.bargull@gmail.com> Fix per anba suggestion
ptomato
force-pushed
the
DurationFormatOrder
branch
from
1ed8220 to
6b8006d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test the order of resolvedOptions in default setting Also add test to check the reading order of options based on the property returned in the default setting resolvedOptions.
tc39/proposal-intl-duration-format#167
tc39/proposal-intl-duration-format#172
https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat.prototype.resolvedOptions
These two PRs are presenting to TC39 2023-09 meeting