Skip to content

Add exceptions to OTel client spans and minor 1.24 server test fixes #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2024
Merged

Add exceptions to OTel client spans and minor 1.24 server test fixes #272

merged 1 commit into from
Jun 12, 2024

Conversation

@cretz
Copy link
Member

@cretz cretz commented Jun 12, 2024 •
edited
Loading

What was changed

  • Record exceptions on OTel traces for client calls
  • Fix test for server 1.24 since updates now fail on workflow terminate
  • Fix test for server 1.24 since schedule backfill count is now different

@cretz cretz requested a review from a team June 12, 2024 13:13
@cretz cretz merged commit bf26249 into temporalio:main Jun 12, 2024
@cretz cretz deleted the otel-updates branch June 12, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cretz @Quinn-With-Two-Ns