Skip to content

Conversation

@roxblnfk
Copy link
Collaborator

@roxblnfk roxblnfk commented Aug 28, 2025

What was changed

Added support for internal/promise v3. This is a react/promise fork with a few important improvements:

  • Code base migrated to PHP 8.1+
  • Added declare(strict_types=1); into all PHP files.
  • Added @yield annotation into the PromiseInterface.
  • The package replaces react/promise v3.
  • Made rejection handler reusable. error_log() is still used by default.
  • Removed exit(255) from RejectionPromise.

Why?

New methods - catch() and finally() instead of deprecated otherwise() and always()
ES6 compatibility - API aligned with JavaScript standards
Library ecosystem migration - some libraries have moved to v3 and dropped v2 support

Checklist

  1. Closes react/promise v3 doesn't work fine #357

Note

based on #647

@roxblnfk roxblnfk requested a review from wolfy-j as a code owner August 28, 2025 10:54
@vercel
Copy link

vercel bot commented Aug 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
php Ready Ready Preview Comment Sep 12, 2025 0:16am

# Conflicts:
#	composer.json
#	psalm-baseline.xml
@roxblnfk roxblnfk merged commit d1bd93a into master Sep 12, 2025
111 of 115 checks passed
@roxblnfk roxblnfk deleted the promises-v3 branch September 12, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

react/promise v3 doesn't work fine

3 participants