-
Notifications
You must be signed in to change notification settings - Fork 53
Promises v3 #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Promises v3 #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
c289c55 to
d577a5a
Compare
wolfy-j
approved these changes
Sep 11, 2025
# Conflicts: # composer.json # psalm-baseline.xml
7102166 to
0a2bc21
Compare
05e4a8f to
06c345d
Compare
06c345d to
2d4cf46
Compare
2d4cf46 to
852d6ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added support for internal/promise v3. This is a react/promise fork with a few important improvements:
declare(strict_types=1);into all PHP files.@yieldannotation into thePromiseInterface.react/promisev3.error_log()is still used by default.exit(255)fromRejectionPromise.Why?
• New methods -
catch()andfinally()instead of deprecatedotherwise()andalways()• ES6 compatibility - API aligned with JavaScript standards
• Library ecosystem migration - some libraries have moved to v3 and dropped v2 support
Checklist
Note
based on #647