Replace React Promise v2 #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
roxblnfk
force-pushed
the
replace-promises
branch
from
16d9d2d to
c8e19f6
Compare
roxblnfk
force-pushed
the
replace-promises
branch
from
f2b63c2 to
c8e19f6
Compare
Merged
wolfy-j
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Replaced
react/promisev2 with forked and fixed ones.Why?
We are stuck on React Promises v2, which the React team does not support at the level we need. We have issues with v2 code throwing deprecations on PHP 8.4 and PHP 8.5. We also have a need for the
@yieldannotation in promises.I forked React Promise v2 and made the necessary changes without breaking backwards compatibility.
declare(strict_types=1);in all files@yieldannotations in thePromiseInterfaceAfter that we can work on v3 and improve it to our requirements.
Checklist