Skip to content

Conversation

@khaile
Copy link
Contributor

@khaile khaile commented May 1, 2025

What was changed

Add spec.required_ruby_version = '>= 3.2.0' to the temporalio/temporalio.gemspec file and update the Rubocop TargetRubyVersion to 3.2.

Why?

Checklist

  1. Closes [Feature Request] Add required_ruby_version >= 3.2.0 back to gemspec #208

  2. How was this tested:

  1. Any docs updates needed?

@khaile khaile requested a review from a team as a code owner May 1, 2025 04:03
@CLAassistant
Copy link

CLAassistant commented May 1, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@khaile khaile changed the title Set required_ruby_version to '>= 3.2.0' in the gemspec Set required_ruby_version to >= 3.2.0 in the gemspec May 1, 2025
@cretz
Copy link
Member

cretz commented May 1, 2025

Thanks!

There was an issue building gems for this with our Rust extension which is why we didn't have it. Can you do me a favor and temporarily enable the GH workflow for build-gems.yml (can just add pull_request: under on:)? Then I'll approve it to run and we'll be able to confirm the gem building part still works as well (then we can remove that temporary GH workflow change and merge).

Or I can do this to your branch if you don't mind.

@khaile
Copy link
Contributor Author

khaile commented May 3, 2025

Hi @cretz, I just updated the GH workflow for build-gems.yml. Please take a look!

@cretz
Copy link
Member

cretz commented May 5, 2025

@khaile - thanks! CI successful! Now that we've confirmed that, if you remove that temporary change to build-gems.yml, I'll happily merge. Thanks for sticking with this.

@khaile
Copy link
Contributor Author

khaile commented May 6, 2025

@cretz done!

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cretz cretz merged commit f1339c4 into temporalio:main May 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add required_ruby_version >= 3.2.0 back to gemspec

3 participants