-
Notifications
You must be signed in to change notification settings - Fork 22
Set required_ruby_version to >= 3.2.0 in the gemspec
#258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
>= 3.2.0 in the gemspec
|
Thanks! There was an issue building gems for this with our Rust extension which is why we didn't have it. Can you do me a favor and temporarily enable the GH workflow for Or I can do this to your branch if you don't mind. |
|
Hi @cretz, I just updated the GH workflow for |
|
@khaile - thanks! CI successful! Now that we've confirmed that, if you remove that temporary change to |
|
@cretz done! |
cretz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What was changed
Add
spec.required_ruby_version = '>= 3.2.0'to thetemporalio/temporalio.gemspecfile and update the Rubocop TargetRubyVersion to 3.2.Why?
Checklist
Closes [Feature Request] Add
required_ruby_version >= 3.2.0back to gemspec #208How was this tested: