Skip to content

Set required_ruby_version to >= 3.2.0 in the gemspec #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2025
Merged

Set required_ruby_version to >= 3.2.0 in the gemspec #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3fe121
Set required_ruby_version to '>= 3.2.0' in then gemspec
khaile May 1, 2025
1e83c22
Allow building gems when opening a PR
khaile May 3, 2025
20bce0b
Remove pull request trigger from build gems workflow
khaile May 6, 2025
50961b0
Merge branch 'main' into chore/add_required_ruby_version
cretz May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@ Gemfile.lock
temporalio/test/golangworker/golangworker
temporalio/.yardoc
temporalio/doc
temporalio/pkg
temporalio/pkg
temporalio/lib/temporalio/internal/bridge/temporalio_bridge.bundle
9 changes: 2 additions & 7 deletions temporalio/.rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ inherit_mode:

AllCops:
NewCops: enable
TargetRubyVersion: 3.1
TargetRubyVersion: 3.2
SuggestExtensions: false
Exclude:
- ext/**/*
Expand All @@ -18,11 +18,6 @@ AllCops:
# Keep cop rule settings in alphabetical order. For each rule setting, provide
# justification for the change from default.

# Temporarily disabled per https://github.com/rake-compiler/rake-compiler-dock/issues/145#issuecomment-2596848639
# until that is fixed
Gemspec/RequiredRubyVersion:
Enabled: false

# We want our classes in a certain order
Layout/ClassStructure:
Enabled: true
Expand Down Expand Up @@ -105,4 +100,4 @@ Style/RequireOrder:

# We are ok with large amount of keyword args
Metrics/ParameterLists:
CountKeywordArgs: false
CountKeywordArgs: false
1 change: 1 addition & 0 deletions temporalio/.tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ruby 3.3.7
1 change: 1 addition & 0 deletions temporalio/temporalio.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Gem::Specification.new do |spec|
spec.require_paths = ['lib']
spec.extensions = ['ext/Cargo.toml']
spec.metadata['rubygems_mfa_required'] = 'true'
spec.required_ruby_version = '>= 3.2.0'

spec.add_dependency 'google-protobuf', '>= 3.25.0'
spec.add_dependency 'logger'
Expand Down
1 change: 0 additions & 1 deletion temporalio/test/contrib/open_telemetry_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# frozen_string_literal: true

require 'opentelemetry/sdk'
require 'set'
require 'temporalio/contrib/open_telemetry'
require 'test'

Expand Down
Loading