Skip to content

Conversation

@mastermanu
Copy link
Member

@mastermanu mastermanu commented Sep 30, 2020

Adds support for passing in client certificate / password data via the configuration through the use of "CertData" and "KeyData" fields respectively.

One can simply do:

cat <certificate or key> | base64 --wrap=0

and then paste the output as a value for each of the fields.

For now, both the client certificate and the key must be passed in via the same style (e.g. passing the certificate via a filepath and its associated key via base64 is not supported). This is not difficult to add, but will only add this if requested.

Verification:

  • Canary and Bench Tests pass against both local and deployed environments that point a Cluster with TLS enabled.

@mastermanu mastermanu marked this pull request as draft September 30, 2020 20:35
@mastermanu mastermanu changed the title (experimental) changes required for Astra support Add ability to specify in client certificate and associated private key via base64 values in config Oct 1, 2020
@mastermanu mastermanu marked this pull request as ready for review October 1, 2020 05:07
@mastermanu mastermanu changed the title Add ability to specify in client certificate and associated private key via base64 values in config Add ability to specify client certificate and associated private key via base64 values in config Oct 1, 2020
@mastermanu mastermanu merged commit 4e9f18e into temporalio:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants