-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add ability to specify client certificate and associated private key via base64 values in config #782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mastermanu
merged 10 commits into
temporalio:master
from
mastermanu:add_support_for_astra
Oct 1, 2020
Merged
Add ability to specify client certificate and associated private key via base64 values in config #782
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cf46334
changes required for astra support
mastermanu 219bd74
Merge branch 'master' of https://github.com/temporalio/temporal into …
mastermanu 66946f3
removes private test rsa key
mastermanu 309baaa
fixes up connect timeout
mastermanu 4e76ea6
revert timeout setting as that actually causes slow-down on deployed …
mastermanu 485e630
addresses PR feedback
mastermanu 992b705
removes astra schema
mastermanu 6c8b98d
adds comment to indicate how fields are used
mastermanu b8bb717
clean up comment
mastermanu c71b78b
fix broken unit test
mastermanu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| What | ||
| ---- | ||
| This directory contains the cassandra schema for every keyspace that temporal owns. The directory structure is as follows | ||
|
|
||
| ``` | ||
| ./schema | ||
| - keyspace1/ | ||
| - keyspace2/ | ||
| - keyspace.cql -- Contains the keyspace definition | ||
| - schema.cql -- Contains the latest & greatest snapshot of the schema for the keyspace | ||
| - versioned | ||
| - v0.1/ | ||
| - v0.2/ -- One directory per schema version change | ||
| - v1.0/ | ||
| - manifest.json -- json file describing the change | ||
| - changes.cql -- changes in this version, only [CREATE, ALTER] commands are allowed | ||
| ``` | ||
|
|
||
| How | ||
| --- | ||
|
|
||
| Q: How do I update existing schema ? | ||
| * Add your changes to schema.cql | ||
| * Create a new schema version directory under ./schema/keyspace/versioned/vx.x | ||
| * Add a manifest.json | ||
| * Add your changes in a cql file | ||
| * Update the unit test within ./tools/cassandra/updateTask_test.go `TestDryrun` with your version x.x | ||
| * Once you are done with these use the ./temporal-cassandra-tool to update the schema | ||
|
|
||
| Q: What's the format of manifest.json | ||
|
|
||
| Example below: | ||
| * MinCompatibleVersion is the minimum schema version that your code can handle | ||
| * SchemaUpdateCqlFiles are list of .cql files containing your create/alter commands | ||
|
|
||
|
|
||
| ``` | ||
| { | ||
| "CurrVersion": "0.1", | ||
| "MinCompatibleVersion": "0.1", | ||
| "Description": "base version of schema", | ||
| "SchemaUpdateCqlFiles": [ | ||
| "base.cql" | ||
| ] | ||
| } | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| CREATE KEYSPACE IF NOT EXISTS temporal WITH replication = { 'class' : 'SimpleStrategy', 'replication_factor' : 1}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.