Check for an existing CHASM component before writing Workflow as component root #8595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Nov 5, 2025
yycptt
approved these changes
Nov 6, 2025
Member
yycptt
left a comment
yycptt
left a comment
There was a problem hiding this comment.
+1 for adding a separate feature flag for workflow chasm node.
|
|
||
| validationContext := chasm.NewContext(context.Background(), root) | ||
| _, err := root.Component(validationContext, chasm.ComponentRef{}) | ||
| if common.IsNotFoundError(err) { |
Member
There was a problem hiding this comment.
it returns NotFound due to which check? Initial versioned transition check?
I thought it kinda like a undefined behavior. But if it works I don't have a objection. we probably want a test to make sure this always work though.
pdoerner
pushed a commit
that referenced
this pull request
Nov 25, 2025
…onent root (#8595) # What changed? - Only add the Workflow root CHASM component if no root component already exists. - I think the overall feature should probably also be behind a feature flag. ## Why? - CHASM Scheduler functional tests are broken without this fix (scheduler mutable states 'become' chasmworkflows)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?