Skip to content

Check for an existing CHASM component before writing Workflow as component root #8595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2025
Merged

Check for an existing CHASM component before writing Workflow as component root #8595

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
258fdc8
Check for an existing CHASM component before writing Workflow as comp…
lina-temporal Nov 4, 2025
e756fea
fix lint
lina-temporal Nov 5, 2025
5758246
use immutable context for validate
lina-temporal Nov 5, 2025
b2bf585
Merge branch 'main' into ms-check-existing-component
lina-temporal Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions service/history/workflow/mutable_state_impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2597,8 +2597,14 @@ func (ms *MutableStateImpl) ApplyWorkflowExecutionStartedEvent(
// Initialize chasm tree once for new workflows.
// Using context.Background() because this is done outside an actual request context and the
// chasmworkflow.NewWorkflow does not actually use it currently.
mutableContext := chasm.NewMutableContext(context.Background(), ms.chasmTree.(*chasm.Node))
ms.chasmTree.(*chasm.Node).SetRootComponent(chasmworkflow.NewWorkflow(mutableContext, ms))
root, ok := ms.chasmTree.(*chasm.Node)
softassert.That(ms.logger, ok, "chasmTree cast failed")

mutableContext := chasm.NewMutableContext(context.Background(), root)
_, err := root.Component(mutableContext, chasm.ComponentRef{})
if common.IsNotFoundError(err) {
Copy link
Member

@yycptt yycptt Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it returns NotFound due to which check? Initial versioned transition check?
I thought it kinda like a undefined behavior. But if it works I don't have a objection. we probably want a test to make sure this always work though.

root.SetRootComponent(chasmworkflow.NewWorkflow(mutableContext, ms))
}
}

event := startEvent.GetWorkflowExecutionStartedEventAttributes()
Expand Down
Loading