Skip to content

Conversation

@pdoerner
Copy link
Contributor

@pdoerner pdoerner commented Nov 14, 2025

What changed?

Changed the condition to check whether the root component of the chasm tree has been initialized for new workflows

Why?

The root component is never actually empty since we are using NewEmptyTree which sets a root component with no type

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

@pdoerner pdoerner requested review from a team as code owners November 14, 2025 00:31
@pdoerner pdoerner enabled auto-merge (squash) November 14, 2025 00:50
@pdoerner pdoerner merged commit a20a839 into temporalio:main Nov 14, 2025
94 of 96 checks passed
@pdoerner pdoerner deleted the ms-chasm-root-init-fix branch November 14, 2025 02:00
pdoerner added a commit that referenced this pull request Nov 25, 2025
…8638)

## What changed?
Changed the condition to check whether the root component of the chasm
tree has been initialized for new workflows

## Why?
The root component is never actually empty since we are using
`NewEmptyTree` which sets a root component with no type

## How did you test it?
- [x] built
- [ ] run locally and tested manually
- [ ] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants