Fix down arrow on Combobox #2902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
laurakwhit
commented
Sep 10, 2025
| closeList(); | ||
| break; | ||
| case 'ArrowDown': | ||
| openList(); |
Collaborator
Author
There was a problem hiding this comment.
With the addition of this line of code we’re clearing the filterValue on openList().
I think it's safe to remove Actually we're calling openList() from ArrowDown here. All it will change is that a user can't hit ESC and then ArrowDown to open the menu again.openList() on:focus as well so if the user goes back to the input after navigating to a menu option it will also clear the filterValue. Adding a check for if the menu is already open instead.
laurakwhit
force-pushed
the
fix-down-arrow-combobox
branch
from
028d2ff to
9db6341
Compare
rossnelson
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Menu options were being reset after entering a filter value in the
Comboboxcomponent and then hitting the down arrow to navigate to a menu option.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
In the
Comboboxcomponent > enter a filter value > hit the down arrowChecklists
Draft Checklist
Merge Checklist
Issue(s) closed
DT-3290Docs
Any docs updates needed?