Skip to content

Fix down arrow on Combobox #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2025
Merged

Fix down arrow on Combobox #2902

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4f3eb1
Remove openList on down arrow
laurakwhit Sep 10, 2025
9db6341
Add check if list is already open
laurakwhit Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/lib/holocene/combobox/combobox.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,6 @@
closeList();
break;
case 'ArrowDown':
openList();
Copy link
Collaborator Author

@laurakwhit laurakwhit Sep 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the addition of this line of code we’re clearing the filterValue on openList().

I think it's safe to remove openList() from ArrowDown here. All it will change is that a user can't hit ESC and then ArrowDown to open the menu again. Actually we're calling openList() on:focus as well so if the user goes back to the input after navigating to a menu option it will also clear the filterValue. Adding a check for if the menu is already open instead.

focusFirstOption();
break;
case 'Enter':
Expand Down
Loading