Adding first iteration over TSX on new tab

[pedroapfilho]

This is the first iteration of the hypothesis of a new tab for tsx code on the examples.

#696

[nickserv]

It seems like the deploy preview is failing on the Prettier script. Please try committing the results of npm run format-docs.

[pedroapfilho]

Hey @nickmccurdy, this is the output:

❯ npm run format-docs

> react-testing-library-docs@ format-docs /Users/pedrofilho/dev/testing-library-docs
> prettier --write '../docs/**/*.mdx'

[error] No matching files. Patterns tried: ../docs/**/*.mdx !**/node_modules/** !./node_modules/** !**/.{git,svn,hg}/** !./.{git,svn,hg}/**
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! react-testing-library-docs@ format-docs: `prettier --write '../docs/**/*.mdx'`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the react-testing-library-docs@ format-docs script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/pedrofilho/.npm/_logs/2020-11-30T22_46_52_939Z-debug.log

I have no idea what's going on

[MatanBobi]

❯ npm run format-docs

> react-testing-library-docs@ format-docs /Users/pedrofilho/dev/testing-library-docs
> prettier --write '../docs/**/*.mdx'

[error] No matching files. Patterns tried: ../docs/**/*.mdx !**/node_modules/** !./node_modules/** !**/.{git,svn,hg}/** !./.{git,svn,hg}/**
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! react-testing-library-docs@ format-docs: `prettier --write '../docs/**/*.mdx'`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the react-testing-library-docs@ format-docs script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/pedrofilho/.npm/_logs/2020-11-30T22_46_52_939Z-debug.log

I have no idea what's going on

Looks like I've forgot to change the path for the format-docs script when doing the migration.
I'll fix that in a different PR so you'll be able to run this :)

[pedroapfilho]

Nice @MatanBobi, Thanks!

[alexkrolick]

@pedroapfilho I merged @MatanBobi 's change - rebase?

[alexkrolick]

We could install a rebase bot

[pedroapfilho]

@MatanBobi I rebased, installed all the packages and ran the npm run format-docs again, and it still fails.

[MatanBobi]

@MatanBobi I rebased, installed all the packages and ran the npm run format-docs again, and it still fails.

@pedroapfilho you've ran the command locally? I've just cloned your fork and pulled your branch, ran it locally and it succeeded. Is the error you're getting the same as before?

It looks like the CI failed for:

4:26:19 PM: (undefined) TypeError: Cannot read property 'value' of undefined

The same happens when I run npm run build locally so that's probably something there..
I might have time to look into it later on today if you need my help :)

[pedroapfilho]

I think that fixing the indentation will fix it

[pedroapfilho]

@MatanBobi I think that everything is fine now, can we push it?

[MatanBobi]

@nickmccurdy since you've commented on the issue, I'd be glad if you'll have a chance to also have a look at this one :)

[MatanBobi]

@pedroapfilho I'm unable to see the latest commit changes (the ones requested), though I do see them in the commit, any ideas?

[pedroapfilho]

As I made the mistake of removing the diff, I just added it back and amended the lest commit

[MatanBobi]

As I made the mistake of removing the diff, I just added it back and amended the lest commit

Cool, missed that, thanks.
Can you please also rename the js file to jsx as I asked in the comment? :)
After that I think we'll be ready to merge.

[pedroapfilho]

I've separated the imports on the 2 tabs, and it's like this now

[MatanBobi]

This looks great, thanks @pedroapfilho!

[MatanBobi]

One last thing I saw, sorry for the trouble.
It looks like there's no selected item on first startup since the defaultValue value is js and not jsx could you please fix that and I'll merge? :)
Thanks and sorry again!

[pedroapfilho]

Oh! I'm sorry about it, my bad! Fixed. I'll start to put tsx it on other examples now!

[MatanBobi]

Looks great, thanks @pedroapfilho!
Merging.