feat: more tsx tabs in RTL setup doc #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you check these conflicts @Liadshiran |
Liadshiran
force-pushed
the
feat/more-tsx-tabs
branch
from
d6d2a21 to
d0ee4ed
Compare
MatanBobi
requested changes
Jul 6, 2021
docs/react-testing-library/setup.mdx
Outdated
| @@ -79,6 +79,7 @@ export { customRender as render } | |||
|
|
|||
| ```tsx title="test-utils.tsx" | |||
| import React, { FC, ReactElement } from 'react' | |||
| import { Omit } from 'react-redux' | |||
There was a problem hiding this comment.
This is redundant as Omit is native in TS :)
https://www.typescriptlang.org/docs/handbook/utility-types.html#omittype-keys
|
Thanks for taking the time @Liadshiran! |
|
And also, here |
|
I added |
MatanBobi
approved these changes
Jul 6, 2021
|
Thanks @Liadshiran and @pedroapfilho! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #696 and started with #700, I added the rest of the code snippets examples in Typescript for the Setup doc of react testing library.