Skip to content

chore: Add vertical scrolling to main window for better compatibility…#6

Closed
v4g4b0nd-0x76 wants to merge 1 commit intotherealaleph:mainfrom
v4g4b0nd-0x76:fix/ui-window-scroll
Closed

chore: Add vertical scrolling to main window for better compatibility…#6
v4g4b0nd-0x76 wants to merge 1 commit intotherealaleph:mainfrom
v4g4b0nd-0x76:fix/ui-window-scroll

Conversation

@v4g4b0nd-0x76
Copy link
Copy Markdown
Contributor

Fixes #5 where GUI content was partially obscured on laptops with short screens.

Problem

The main window content overflowed on devices with limited vertical space, making some UI elements inaccessible without resizing the window.

Solution

  • Wrapped CentralPanel content in ScrollArea::vertical() with .auto_shrink([false; 2])
  • Ensures all UI elements (config form, stats, logs) remain accessible regardless of screen height
  • Nested scroll areas (per-site stats, logs) continue to function correctly within the main scrollable area

@therealaleph
Copy link
Copy Markdown
Owner

Thanks @v4g4b0nd-0x76 — shipped in v0.7.1 (835a705). Applied the two functional changes (ScrollArea + lower min window height) on top of current main. Co-authored-by trailer is on the commit. 🙏

therealaleph added a commit that referenced this pull request Apr 25, 2026
Two user-reported issues.

=== GLIBC too new (reported via twitter) ===

Our linux-amd64 and linux-arm64 gnu builds were compiled on
ubuntu-latest (24.04, GLIBC 2.39), which means the resulting binaries
refuse to load on anything older:

  ./mhrv-rs: /lib/x86_64-linux-gnu/libc.so.6: version 'GLIBC_2.39'
    not found (required by ./mhrv-rs)

Users on Ubuntu 22.04 / Mint 21 (GLIBC 2.35) — the typical user in Iran
where this project's target audience lives, and where they can't
dist-upgrade because they're behind exactly the kind of network
restriction this tool exists to bypass — could not run the gnu builds
at all.

Fix: pin the linux-gnu matrix entries to ubuntu-22.04 runners. GLIBC
2.35 is now the minimum; binaries load on Ubuntu 22.04, Mint 21,
Debian 12, Fedora 36+, RHEL 9+ and everything newer.

Users on older distros (Ubuntu 20.04, CentOS 7) can still use the
static musl builds (mhrv-rs-linux-musl-amd64.tar.gz et al.) which
have no GLIBC dependency at all.

=== Short-screen laptops — main window content clipped (PR #6) ===

Co-authored fix from @v4g4b0nd-0x76 in PR #6 (manually applied to
avoid pulling in 400 lines of unrelated cargo-fmt churn):

- Wrap the CentralPanel body in ScrollArea::vertical()
  .auto_shrink([false; 2]) so everything stays reachable on short
  screens.
- Lower the min_inner_size from [420, 540] to [420, 400] so laptops
  with ~13" screens at default scaling can shrink the window without
  clipping UI elements.

Closes #6.

Co-authored-by: v4g4b0nd-0x76 <v4g4b0nd-0x76@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't Scroll down on the UI version

2 participants