drm/i915: apply AUD_FREQ_CNTRL state save to all GEN9+ platforms #1881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the TGL/ICL specific platform checks with a more generic check using INTEL_GEN(). An initial version of state save and restore of AUD_FREQ_CNTRL register was added for subset of platforms in commit 87c1694 ("drm/i915: save AUD_FREQ_CNTRL state at audio domain suspend"). The state save has proven to work well and it is needed in newer platforms, so needs to be extended. Although the logic is not strictly needed on GEN9/10, align change to hardware specification and apply state and restore to all platforms since GEN9. Bspec: 49281 Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
added
upstream
kv2019i
requested review from
dbaluta,
lgirdwood,
plbossart and
ranj063
as code owners
plbossart
approved these changes
Mar 10, 2020
|
Review still ongoing on intel-gfx... keeping open |
|
Merged upstream and version merge to sof-dev as well (#1881). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the TGL/ICL specific platform checks with a more generic
check using INTEL_GEN().
An initial version of state save and restore of AUD_FREQ_CNTRL
register was added for subset of platforms in commit 87c1694
("drm/i915: save AUD_FREQ_CNTRL state at audio domain suspend").
The state save has proven to work well and it is needed
in newer platforms, so needs to be extended. Although the logic is not
strictly needed on GEN9/10, align change to hardware specification and
apply state and restore to all platforms since GEN9.
Bspec: 49281
Signed-off-by: Kai Vehmanen [email protected]
Fixes: #1719