-
Notifications
You must be signed in to change notification settings - Fork 26
Nested import handling #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ling change in import order when css files are imported via javascript files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not actively using this, so if someone else can confirm that this is what they expect, I will merge this.
@@ -1,14 +1,43 @@ | |||
import { createFilter } from '@rollup/pluginutils' | |||
|
|||
var arraysEqual = function(a, b) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind moving helper functions to the bottom of the file?
Also, I prefer
var arraysEqual = function(a, b) { | |
function arraysEqual(a, b) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be ok if I created a util.js (or similar) file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not, I will move to the bottom of the file as suggested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bottom seems fine :-)
This PR should address #28
Changes
This PR does 3 things:
Illustration
Import Structure
Output Structure
Notes