-
Notifications
You must be signed in to change notification settings - Fork 26
CSS imports #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v4
Are you sure you want to change the base?
CSS imports #31
Conversation
src/index.js
Outdated
|
||
return { | ||
name: 'css', | ||
buildStart() { | ||
hasChanged = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a build takes 10s and you save an irrelevant file after 5s, hasChanged
will be false at the moment that generateBundle takes place. I think this might introduce a race-condition. Does this change address a bug in the current version?
Maybe we should remove all change detection to make things simpler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That change is from my pull request. You raise a good point, I’ll think about what to do about this and update my PR
Can you further discuss this with @jerekshoe and merge it into the v4 branch? |
Co-authored-by: Thomas Ghysels <[email protected]>
based on #29
parses
@import './test.css'
lines in CSS files and adds them as imports within rollup,e.g.,
will create the following intermediate JS module
Thus, triggers import the imported files during bundling.