Merged
Conversation
deadprogram
reviewed
Feb 4, 2026
deadprogram
reviewed
Feb 4, 2026
deadprogram
reviewed
Feb 4, 2026
Member
|
Is there a specific reason the |
Collaborator
Author
To exclude it from the Go build system at the top module level. This prevents lneto appearing as a dependency of the pio package. Is there a better way? Will address the rest of your comments in time. Still trying to figure out a way to go from 8% to ~0% packet loss regarding the PIO program comments |
Collaborator
Author
|
This is working! |
Member
|
I will give this a more serious review now. Getting exciting! |
deadprogram
reviewed
Feb 25, 2026
| var err error | ||
| time.Sleep(2 * time.Second) | ||
| println("=== RMII Loopback Test ===") | ||
| // var mdio MDIOBitBang |
deadprogram
reviewed
Feb 25, 2026
Member
|
Amazing work here @soypat 🎆 Now squash/merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So last byte is processed weirdly, but rest of frame is transmitted via loopback correctly! We have working RMII in TinyGo!