test: run tests for AVR #1528
Closed
test: run tests for AVR #1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This runs the currently working compiler tests for AVR using simavr. I picked the atmega1284p target as it seems like the most suitable one (most importantly, with a lot of RAM) so that tests are less likely to hit resource limitations. One extra change this required is using a different implementation of the runtime.abort() function. The new one is smaller and will prevent interrupts from running on exit, which should at least in theory be fine. This pattern is required as it signals to simavr the program is finished.
|
I am surprised that I missed this when making #2458, but I think this is no longer needed. |
|
Yeah, this PR was way outdated anyway and much simpler now that simavr is widely available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs the currently working compiler tests for AVR using simavr. I
picked the atmega1284p target as it seems like the most suitable one
(most importantly, with a lot of RAM) so that tests are less likely to
hit resource limitations.
One extra change this required is using a different implementation of
the runtime.abort() function. The new one is smaller and will prevent
interrupts from running on exit, which should at least in theory be
fine. This pattern is required as it signals to simavr the program is
finished.
Now that #1520 is ready, I want to work towards better AVR support and dropping the gcc-avr and avr-libc dependencies if possible. One way to track progress is by getting tests to pass, both to show improvements in new PRs and to catch regressions.