Skip to content

main (test): run tests on AVR #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 1, 2022
Merged

main (test): run tests on AVR #2458

merged 2 commits into from
Jan 1, 2022

Conversation

niaow
Copy link
Member

@niaow niaow commented Jan 1, 2022

This is still somewhat WIP. This doesn't intend to fix any of these bugs, just to ensure that we do not pick up more.

Copy link
Member

@aykevl aykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This looks reasonable. In fact, I've wanted to write this patch for some time now but never got around to actually do it.

t.Run("AVR", func(t *testing.T) {
// LLVM backend crash:
// LIBCLANG FATAL ERROR: Cannot select: t3: i16 = JumpTable<0>
// This bug is non-deterministic, and only happens when run concurrently with non-AVR tests.
Copy link
Member

@aykevl aykevl Jan 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh. Yeah that's bad. I hope we can fix this (after this PR is merged, in LLVM probably).

@niaow niaow marked this pull request as ready for review January 1, 2022 04:19
@niaow
Copy link
Member Author

niaow commented Jan 1, 2022

Huh, actually this seems ready

@aykevl aykevl merged commit e536676 into tinygo-org:dev Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants