internal/task: remove coroutines #2448
Conversation
niaow
force-pushed
the
remove-coroutines
branch
from
58d2bd9 to
2b609e2
Compare
|
This is a bit bigger than I expected, so I don't think it is necessarily a good idea to include this for this release. Next release cycle I would like to refactor a lot of the things that used to depend on coroutines. |
There was a problem hiding this comment.
Phew! That's indeed a big PR. I did expect it to be pretty big though...
I think I would have tried to split this into multiple commits (remove coroutines scheduler, remove switch implementation of functions, and then remove the parentHandle parameter). But I'm not going to complain.
We might want to test AVR some more just to be sure, see below.
Anyway, giving a preliminary LGTM now.
| case "none", "coroutines": | ||
| // As "doubleword", but with the function pointer replaced by a unique | ||
| // ID per function signature. Function values are called by using a | ||
| // switch statement and choosing which function to call. | ||
| // Pick the switch implementation with the coroutines scheduler, as it | ||
| // allows the use of blocking inside a function that is used as a func | ||
| // value. | ||
| return "switch" |
There was a problem hiding this comment.
FYI: this does have an effect on AVR which used -scheduler=none by default. This used to be necessary because function pointers used to be buggy in AVR but I believe it should work now (except a very small increase in binary size sometimes which I think is acceptable).
Yeah, I can try to do that |
niaow
force-pushed
the
remove-coroutines
branch
from
2b609e2 to
ef2fec3
Compare
|
This PR has now been split into 3 less-huge commits. |
niaow
force-pushed
the
remove-coroutines
branch
from
ef2fec3 to
66a98ef
Compare
The switched func lowering was mainly necessary for coroutines. With coroutines removed, this is no longer necessary.
This removes the parentHandle argument from the internal calling convention. It was formerly used to implment coroutines. Now that coroutines have been removed, it is no longer necessary.
niaow
force-pushed
the
remove-coroutines
branch
from
66a98ef to
d239909
Compare
|
I need to look into why there is an issue with the closure on Windows. |
|
It seems to be a random error. . . which is concerning. I also distinctly remember running into that exact error before (so I don't think it is caused by this PR). I strongly suspect that the actual fix is #2433, which I now realize I forgot to finish debugging. |
|
I created #2551 for now |
|
IDK, does anyone object to merging this now? |
|
I'm all for merging it if it will prevent bad user experiences. We can always resurrect coroutines later... |
No description provided.