-
Notifications
You must be signed in to change notification settings - Fork 951
ci: try to build LLVM with thread support #2433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3e16267
to
b5aaa71
Compare
Ready for review! This seems to be working. |
I think this is the underlying issue for #775. |
The smoketests seem to be taking quite a while to run, not sure if something broke |
They do sometimes, not sure why. They're running on Linux so it's unrelated to this PR. |
b5aaa71
to
d4f7df9
Compare
Seems like it is the Windows smoke tests that are getting stuck. |
I think I hit something with smoke tests getting stuck on windows back when I added asyncify, however I thought I fixed it. |
If I remember correctly, the issue was that there was some crash happening and the default behavior was to stop the running process rather than exiting. I do not remember what was triggering the crash though, and I cant seem to find it. |
Nevermind, I remembered incorrectly. I encountered this issue in #2035 |
It could potentially be this: #2035 (comment) |
Nevermind, I think I was a bit tired when writing that comment. |
Probably not, because it's stuck here:
This is not WebAssembly so I should also add that the whole point of this PR is to fix a problem on Windows when LLVM was built with assertions enabled. I got an assertion failure every time unless I compiled with |
That makes sense, although I still strongly suspect this is at least a similar issue.
I can try this once I finish what I am currently working on then. |
So I got an assert build to compile, but then clang crashed while building wasi-libc crash log
The backtrace here is unfortunately not too helpful. I might try to see if I can get more info with a debugger, but it looks like we have some issue with |
GDB seems to be a bit more helpful GDB backtrace
|
I think I may need to rebuild with debug symbols to get enough info to figure out what is going on |
d4f7df9
to
799aadd
Compare
Rebased and testing some more...
I've reported this upstream here: llvm/llvm-project#55120 |
799aadd
to
459f8c6
Compare
459f8c6
to
683381d
Compare
This should fix a number of concurrency/threading issues.
683381d
to
f4f2b8e
Compare
This doesn't seem to work, unfortunately. Not sure what's going on: the "TinyGo Test" step hangs. It looks like I think I'm giving up on this for now. |
This should fix a number of concurrency/threading issues.