-
Notifications
You must be signed in to change notification settings - Fork 951
Add os/file.Truncate #4209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add os/file.Truncate #4209
Conversation
a116c85
to
b345be7
Compare
e8dac1d
to
0851695
Compare
any update on next steps ? |
e3e4e5a
to
67055fc
Compare
CI error does not seem to be related to the
|
@leongross that seems fixed in 0.29.0 |
67055fc
to
36922f1
Compare
@leongross can you please rebase this PR against the latest |
36922f1
to
3cf309c
Compare
@deadprogram rebase done |
3cf309c
to
62ee709
Compare
Looking for review / approval ! TY |
Conflicts after the wasip2 merge. This probably needs a wasip2 implementation but I'm fine to merge this with a |
1b3eb6a
to
29f7137
Compare
You should be able to stub this for wasip2 with this addition to
|
aacb147
to
eded7df
Compare
@leongross please see error here https://github.com/tinygo-org/tinygo/actions/runs/10009754889/job/27670027039?pr=4209#step:7:37 Probably something needs an additional build tag for Windows? |
eded7df
to
5d7ce32
Compare
5d7ce32
to
48d9ab9
Compare
Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
48d9ab9
to
088e95e
Compare
Looks like we encountered a similar error as a few weeks ago @deadprogram
EDIT: apart from the llvm packaging failure the ci passes, would appreciate a review @ayang64 @dgryski @rminnich @deadprogram |
Signed-off-by: leongross <[email protected]>
088e95e
to
f37e3f5
Compare
llvm issues seem to be resolved by now, re-running the CI |
CI is green, ready to merge? @aykevl @deadprogram @dgryski @rminnich |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks for taking care of that @aykevl! |
Add
file.Truncate()
tofile.go