Skip to content

add os.Truncate(name, size) (see #4209) #4401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2024
Merged

add os.Truncate(name, size) (see #4209) #4401

merged 1 commit into from
Aug 11, 2024

Conversation

archie2x
Copy link
Contributor

@archie2x archie2x commented Aug 9, 2024 •
edited
Loading

See https://pkg.go.dev/os#Truncate

@leongross authored #4209 which defined the *os.File receiver Truncate but was missing os.Truncate(filename, size).

@archie2x archie2x marked this pull request as ready for review August 9, 2024 10:00
dgryski
dgryski approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@dgryski dgryski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deadprogram
Copy link
Member

Now merging, thank you @archie2x for the addition and to @dgryski for review.

@deadprogram deadprogram merged commit d6e73b4 into tinygo-org:dev Aug 11, 2024
17 checks passed
@archie2x archie2x deleted the os/file/truncate branch August 14, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgryski dgryski dgryski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@archie2x @deadprogram @dgryski