Repository navigation
riscv: implement VirtIO target - #976
Merged
Merged
Conversation
Closed
This allows running RISC-V tests in CI using QEMU, which should help catch bugs.
Member
|
Since there appear to be changes that also affect the hardware implementation, I will test on my actual board later today. |
Member
Author
|
It only moves code around, so it's very unlikely to change in behavior (it may not even change the binary). |
Member
|
Behavior verified, so now merging. |
aykevl
added a commit
that referenced
this pull request
Apr 5, 2020
This probably got broken with this PR: #976
aykevl
added a commit
that referenced
this pull request
Apr 7, 2020
This probably got broken with this PR: #976
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows running RISC-V tests in CI using QEMU, which should help catch bugs.
This PR is an improvement over #765 in that it doesn't hack around the lack of a test finisher but instead uses a new target (
-target=riscv-qemu) that is based on VirtIO and actually includes a way to exit the QEMU process.