Skip to content

Conversation

@nokhnaton
Copy link
Contributor

@nokhnaton nokhnaton commented May 10, 2025

スタンプのバグはまだ直してない
ここでrevertして修正して修正した部分を、revertしないで修正
ここのrevertで「ここから未読」の位置を修正し、未読を消す処理ごとrevertされてるので、これを戻してこのPRを入れたら直るはず
#4562

@github-actions
Copy link

@nokhnaton
Copy link
Contributor Author

あれ?スタンプのバグ直ってそう?よくわからん

@nokhnaton nokhnaton marked this pull request as ready for review May 10, 2025 13:57
@codecov
Copy link

codecov bot commented May 10, 2025

Codecov Report

❌ Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.90%. Comparing base (98d2ffb) to head (d9607b6).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...MessagesScroller/composables/useMessagesFetcher.ts 0.00% 17 Missing ⚠️
...ain/MainView/MessagesScroller/MessagesScroller.vue 0.00% 13 Missing ⚠️
...ponents/Main/MainView/QallView/QallMessageView.vue 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4565      +/-   ##
==========================================
- Coverage   11.91%   11.90%   -0.01%     
==========================================
  Files         695      695              
  Lines       31182    31206      +24     
  Branches      616      616              
==========================================
  Hits         3714     3714              
- Misses      27456    27480      +24     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nokhnaton nokhnaton requested a review from Takeno-hito June 6, 2025 10:05
@Takeno-hito
Copy link
Member

元々の PR はこれ #4395

#4395 -> #4562 で一部コミット revert → フォローアップで今なはず

@Takeno-hito Takeno-hito requested a review from cp-20 July 20, 2025 12:10
@Takeno-hito Takeno-hito merged commit 52b3f1e into master Jul 27, 2025
11 checks passed
@Takeno-hito Takeno-hito deleted the fix/scroller_bug branch July 27, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants