Skip to content

traQにフォーカスしてないユーザーの表示を変更する。 #4395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Takeno-hito merged 10 commits into from
May 10, 2025
Merged

traQにフォーカスしてないユーザーの表示を変更する。 #4395

Takeno-hito merged 10 commits into from
May 10, 2025

Conversation

@nokhnaton
Copy link
Contributor

@nokhnaton nokhnaton commented Oct 26, 2024 •
edited
Loading

使い勝手が変わる部分もあるのでいろんな人の意見がほしいかも

@github-actions
Copy link

github-actions bot commented Oct 26, 2024

Preview (prod) → https://4395-prod.traq-preview.trapti.tech/
Preview (dev) → https://4395-dev.traq-preview.trapti.tech/

@Takeno-hito
Copy link
Member

Takeno-hito commented May 7, 2025 •
edited
Loading

機能面ではないよりましとして入れてしまって良さそう

@codecov
Copy link

codecov bot commented May 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 161 lines in your changes missing coverage. Please review.

Project coverage is 8.86%. Comparing base (b15080a) to head (53be2d6).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...ain/MainView/MessagesScroller/MessagesScroller.vue 0.00% 30 Missing ⚠️
...View/ChannelViewContent/ChannelViewContentMain.vue 0.00% 21 Missing ⚠️
...ponents/Main/MainView/QallView/QallMessageView.vue 0.00% 21 Missing ⚠️
src/components/UI/UserIconEllipsisList.vue 0.00% 18 Missing ⚠️
src/views/composables/useViewStateSender.ts 0.00% 18 Missing ⚠️
src/composables/useCurrentViewers.ts 0.00% 15 Missing ⚠️
...iew/ChannelSidebar/ChannelSidebarViewersDetail.vue 0.00% 12 Missing ⚠️
...nents/Main/MainView/DMView/DMSidebar/DMSidebar.vue 0.00% 7 Missing ⚠️
...View/ChannelView/ChannelSidebar/ChannelSidebar.vue 0.00% 4 Missing ⚠️
...mponents/Main/MainView/ChannelView/ChannelView.vue 0.00% 4 Missing ⚠️
... and 6 more
Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #4395      +/-   ##
=========================================
- Coverage    8.93%   8.86%   -0.07%     
=========================================
  Files         671     672       +1     
  Lines       29658   29867     +209     
  Branches      528     528              
=========================================
  Hits         2649    2649              
- Misses      27003   27212     +209     
  Partials        6       6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@reiroop reiroop self-requested a review May 8, 2025 03:57
@reiroop
Copy link
Contributor

reiroop commented May 8, 2025

複数重なると縁取りとアイコンがかぶるところがちょっと見辛いかも
スクリーンショット 2025-05-08 16 44 41

@reiroop
Copy link
Contributor

reiroop commented May 8, 2025

わかんないけど良さそうな気がする

@Takeno-hito
Copy link
Member

Takeno-hito commented May 8, 2025 •
edited
Loading

複数重なると縁取りとアイコンがかぶるところがちょっと見辛いかも
スクリーンショット 2025-05-08 16 44 41

これって例えばユーザーアイコンの後ろに opacity 100% の背景みたいなのをつけたら解決したりしないかな（アイコン同士がかぶる問題はこれで解決する気がする）

@nokhnaton
Copy link
Contributor Author

nokhnaton commented May 8, 2025

修正しました～

@reiroop
Copy link
Contributor

reiroop commented May 9, 2025

Screenshot_2025-05-09-09-42-20-91_40deb401b9ffe8e1df2f1cc5ba480b12
良さげ？

@reiroop
Copy link
Contributor

reiroop commented May 9, 2025

@nokhnaton わざわざ言うのもなと思ってこっちで変更入れたので、確認お願い

Takeno-hito
Takeno-hito reviewed May 9, 2025
View reviewed changes
Copy link
Member

@Takeno-hito Takeno-hito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

横からレビューしちゃうけど2箇所だけ確認お願いします！

src/composables/useCurrentViewers.ts Outdated
const currentViewers = ref<ChannelViewer[]>([])

/**
* チャンネルを見ている人(入力中、バックグラウンド表示中も含む)のIDの一覧(古い順)
Copy link
Member

@Takeno-hito Takeno-hito May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* チャンネルを見ている人(入力中、バックグラウンド表示中も含む)のIDの一覧(古い順)
* チャンネルを見ている人(入力中を含む、バックグラウンド表示を除く)のIDの一覧(古い順)

src/composables/useCurrentViewers.ts Outdated
* チャンネルを見ている人(入力中、バックグラウンド表示中も含む)のIDの一覧(古い順)
*/
const viewingUsers = computed(() => currentViewers.value.map(v => v.userId))
const viewingUsers = computed(() =>
Copy link
Member

@Takeno-hito Takeno-hito May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inactiveUser がなくなるなら本当は activeViewingUsers の方が良さそうだけど今から変えるの骨が折れそうなので別に置いておいてもいいかも…

@Takeno-hito Takeno-hito requested a review from reiroop May 9, 2025 15:13
@Takeno-hito
Copy link
Member

Takeno-hito commented May 10, 2025

ok そう！reiくんのレビュー待ちで

@Takeno-hito Takeno-hito merged commit 3b7b8b4 into master May 10, 2025
10 of 11 checks passed
@Takeno-hito Takeno-hito deleted the feat/transparent_inactive_user branch May 10, 2025 10:41
@ACF37 ACF37 mentioned this pull request Jun 27, 2025
Merged
3 tasks
@Takeno-hito Takeno-hito mentioned this pull request Jul 20, 2025
Merged
@Takeno-hito Takeno-hito mentioned this pull request Aug 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Takeno-hito Takeno-hito Takeno-hito left review comments

@ras0q ras0q ras0q left review comments

@reiroop reiroop reiroop approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nokhnaton @Takeno-hito @reiroop @ras0q