自分はChannelViewStateに関わらず閲覧中とする #4649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://4649-prod.traq-preview.trapti.tech/ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4649 +/- ##
==========================================
+ Coverage 8.69% 10.04% +1.35%
==========================================
Files 694 694
Lines 31045 31060 +15
Branches 536 536
==========================================
+ Hits 2699 3120 +421
+ Misses 28339 27933 -406
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pugma
approved these changes
Jun 30, 2025
Contributor
Pugma
left a comment
Pugma
left a comment
There was a problem hiding this comment.
実装方針の変更に伴って PR 名称と内容に乖離ができていそうです
そこだけ変更をお願いします…！
他はよさそうなので approve 出しておきます
tufusa
reviewed
Jun 30, 2025
Member
tufusa
left a comment
tufusa
left a comment
There was a problem hiding this comment.
#4649 (review) に相違ないです🙇
仕様の変更になると思うので、自分はChannelViewStateに関わらず閲覧中とするのようなコメントがあるとより良いかもです！
ACF37
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
チャンネルを開いていても最新のメッセージを読み込んでいない場合にアイコンが暗転していた。最新のメッセージを読み込んでいない場合でもアイコンが暗転しないようにした。
なぜこの PR を入れたいのか
#4610
動作確認の手順
スクロールしないと最新のメッセージが読み込まれないような古いメッセージを読み込む。引用から、または検索から飛ぶのが楽。
UI 変更部分のスクリーンショット
before
after
PR を出す前の確認事項
見てほしいところ・聞きたいことなど
おそらく #1808 の実装を #4395 で使っているのですが、ChannelViewStateを当時の設計から変更しているので確認してほしいです。