Skip to content

feat(langchain): implement emitting events in addition to current behavior #2889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 11, 2025
Merged

feat(langchain): implement emitting events in addition to current behavior #2889

merged 14 commits into from
Jul 11, 2025

Conversation

LuizDMM
Copy link
Contributor

@LuizDMM LuizDMM commented May 5, 2025

✅ PR Requirements

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation):
  • (If applicable) I have updated the documentation accordingly.

📌 Issue Requirements

  • Make sure to keep the current way of emitting events and the new (event-based) way with the official semantic
  • Add a config to each instrumentation called use_legacy_attributes which defaults to true, and if set to false emit events instead of the prompt / completion attributes.
  • Propagate a new initialization parameter of the SDK called use_legacy_attributes that sets this config in all instrumentations.

LuizDMM added 3 commits May 3, 2025 08:04
@LuizDMM
feat(langchain): implement the support to emitting events in addition…
913fa9c 
… to current behavior

* Add "use_legacy_attributes" to Config and the Instrumentor constructor, defaulting to True;
* emit events for user prompts and AI responses, following [OpenTelemetry semantic conventions](https://opentelemetry.io/docs/specs/semconv/gen-ai/gen-ai-events/\\\);
* introduce a privacy safeguard by checking the OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT environment variable to enable or disable content capture in events;
* implement comprehensive tests to verify the new functionality and ensure that, when use_legacy_attributes == True, the existing behavior remains unchanged;
@LuizDMM
fix(openai): revert unnecessary changes in last commit due to PR spli…
7ebf369 
…tting
@LuizDMM
feat(langchain): add event_handler module and refactor events logic
e4a0971 
- Introduce TypedDicts and dataclasses to standardize inputs for event handling;
- Add `emit_event` method to encapsulate all event emission logic via `Event` instances;
- Refactor instrumentation to use `emit_event`, improving clarity and maintainability.
@ellipsis-dev ellipsis.dev
Copy link
Contributor

ellipsis-dev bot commented May 5, 2025

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at [email protected]

Generated with ❤️ by ellipsis.dev

@LuizDMM LuizDMM changed the title feat(langchain): implement emitting events in addition to current behaviour feat(langchain): implement emitting events in addition to current behavior May 5, 2025
@cursor Cursor
Copy link

cursor bot commented Jul 5, 2025

🚨 BugBot couldn't run

Something went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_43b90518-6947-4e9b-bab1-c59574709513).

nirga
nirga approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're reverting several changes we've incorporated in callback_handler, can you take a look?

@cursor Cursor
Copy link

cursor bot commented Jul 11, 2025

🚨 BugBot couldn't run

Something went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_93ce9dcb-576e-49c5-bb5d-654aa14c71db).

@nirga nirga merged commit b58201f into traceloop:main Jul 11, 2025
9 checks passed
ronensc
ronensc reviewed Jul 14, 2025
View reviewed changes
...telemetry-instrumentation-langchain/opentelemetry/instrumentation/langchain/event_handler.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed this file is empty. Is it intentional, or should it be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ronensc, I'm taking a look in my branch here, if any code was lost in the merges, I'll remove it if it isn't necessary anymore, thank you for point out.

@LuizDMM
Copy link
Contributor Author

LuizDMM commented Jul 14, 2025

I think you're reverting several changes we've incorporated in callback_handler, can you take a look?

Hey @nirga, I'll take a look here in the merges I did and fix if that's the case, sorry for the delay, I hadn't seen your comment.

amitalokbera pushed a commit to amitalokbera/openllmetry that referenced this pull request Jul 15, 2025
@LuizDMM @nirga @amitalokbera
feat(langchain): implement emitting events in addition to current beh…
49c5b72 
…avior (traceloop#2889)

Co-authored-by: Nir Gazit <[email protected]>
@ronensc ronensc mentioned this pull request Jul 30, 2025
Merged
4 tasks
ronensc
ronensc reviewed Aug 5, 2025
View reviewed changes
...emetry-instrumentation-langchain/opentelemetry/instrumentation/langchain/callback_handler.py

@dont_throw
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuizDMM Could you please clarify the reason for removing @dont_throw from on_llm_end()?

@LuizDMM LuizDMM mentioned this pull request Aug 6, 2025
Merged
4 tasks
nina-kollman pushed a commit that referenced this pull request Aug 11, 2025
@LuizDMM @nirga
feat(langchain): implement emitting events in addition to current beh…
bf4fa53 
…avior (#2889)

Co-authored-by: Nir Gazit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronensc ronensc ronensc left review comments

@nirga nirga nirga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuizDMM @nirga @ronensc