-
Notifications
You must be signed in to change notification settings - Fork 797
fix(langchain): Add "dont_throw" to "on_llm_end" and remove blank file #3232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(langchain): Add "dont_throw" to "on_llm_end" and remove blank file #3232
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 8313eb6 in 47 seconds. Click for details.
- Reviewed
15
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/opentelemetry-instrumentation-langchain/opentelemetry/instrumentation/langchain/callback_handler.py:477
- Draft comment:
Good fix: adding @dont_throw here ensures on_llm_end handles errors consistently like other callbacks. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is purely informative, as it praises the fix and explains what the change does without suggesting any improvements or asking for clarifications. It doesn't align with the rules for useful comments.
2. packages/opentelemetry-instrumentation-langchain/opentelemetry/instrumentation/langchain/event_handler.py:1
- Draft comment:
Removal of the empty event_handler.py file is appropriate. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_upao0cAzbh98A8w4
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
8313eb6
to
15498d4
Compare
Template Questions
feat(instrumentation): ...
orfix(instrumentation): ...
.Description
I left an empty file (I think it was left during some merges and moving code around) on my last PR about langchain and also forget to add back a
@dont_throw
I think I removed while testing, as pointed out by @ronensc (thank you man 😁), fixing those problems.Important
Add
@dont_throw
toon_llm_end
incallback_handler.py
and remove emptyevent_handler.py
.@dont_throw
decorator toon_llm_end
incallback_handler.py
to handle exceptions gracefully.event_handler.py
file.This description was created by
for 8313eb6. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit