Skip to content

add additional failing test for ModelAdmin generic #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Oct 28, 2020
Merged

add additional failing test for ModelAdmin generic #505

merged 1 commit into from Oct 28, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 28, 2020

this will ensure that the generic constraint holds

i have made things!

related issues

refs #482, #504

i wanted to add an additional test just to fully make sure the generic ModelAdmin won't typecheck when it shouldn't

this will ensure that the generic constraint holds
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@sobolevn sobolevn merged commit e2f6abe into typeddjango:master Oct 28, 2020
@ghost
Copy link
Author

ghost commented Oct 28, 2020

no problem! thanks for working with me on this, django-stubs has been super helpful

@ghost ghost deleted the issue-482-test branch November 1, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant