-
-
Notifications
You must be signed in to change notification settings - Fork 127
Fix type of data parameter in get test requests #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type of data parameter in get test requests #267
Conversation
The import paths seem to be wrong in the original code, hence why the tests are broken. |
The CI has been fixed |
6b76c3e
to
72624b6
Compare
72624b6
to
9f4bc38
Compare
CI fixed again, sorry! I rebased your branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR
A similar change would be helpful in |
The lint and test are failing because an But typecheck fails due to changes in upstream DRF tests; I'll fix that in a bit. |
7eb9c06
to
5f497ee
Compare
From typecheck output
Maybe we should accept If there are still remaining typecheck errors after that, we should just suppress them via |
5f497ee
to
f920e73
Compare
Lists of two-tuples of strings are allowed Co-authored-by: Marti Raudsepp <[email protected]>
f920e73
to
973b707
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I've neglected this project a bit while I focused on django-stubs. Rest assured, I haven't forgotten about it. :)
I rebased your branch, there are some false positives in CI typecheck which shoud probably be added to ignores list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed the relevant typecheck ignores and this can now be merged. Thanks!
Lists of two-tuples of strings are allowed in the data attribute for get requests
Example of a false-positive needing this fix: