Fix type of data parameter in get test requests#267
Conversation
|
The import paths seem to be wrong in the original code, hence why the tests are broken. |
|
The CI has been fixed |
6b76c3e to
72624b6
Compare
72624b6 to
9f4bc38
Compare
|
CI fixed again, sorry! I rebased your branch. |
|
A similar change would be helpful in |
|
The lint and test are failing because an But typecheck fails due to changes in upstream DRF tests; I'll fix that in a bit. |
7eb9c06 to
5f497ee
Compare
|
From typecheck output
Maybe we should accept If there are still remaining typecheck errors after that, we should just suppress them via |
5f497ee to
f920e73
Compare
Lists of two-tuples of strings are allowed Co-authored-by: Marti Raudsepp <marti@juffo.org>
f920e73 to
973b707
Compare
intgr
left a comment
There was a problem hiding this comment.
Sorry, I've neglected this project a bit while I focused on django-stubs. Rest assured, I haven't forgotten about it. :)
|
I rebased your branch, there are some false positives in CI typecheck which shoud probably be added to ignores list. |
intgr
left a comment
There was a problem hiding this comment.
I pushed the relevant typecheck ignores and this can now be merged. Thanks!
Lists of two-tuples of strings are allowed in the data attribute for get requests
Example of a false-positive needing this fix: