Skip to content

Conversation

@intgr
Copy link
Contributor

@intgr intgr commented Sep 29, 2025

NOTE: Duplicate PR of #832. The previous one was targeting the wrong branch - my mistake. 🤦


As discussed in uv PR -- #797 (comment)

  • After switching to uv package manager, uv.lock pins the git commit hashes used when pulling django-stubs/django-stubs-ext. BUT: we don't want it to remain pinned -- if there's an incompatible change in upstream, we want to know of it.
  • Configured Renovate to update the file daily (we'll see, maybe that's too frequent).
  • If the "test" GitHub workflow passes, Renovate will auto-merge. Otherwise it will open a PR.
  • Renovate automerge documentation: https://docs.renovatebot.com/key-concepts/automerge/
  • Closes Configure Renovate #834

As discussed in `uv` PR:

* `uv.lock` pins the git commit hashes used when pulling `django-stubs`/`django-stubs-ext`. But if there's an incompatible change in there, we want to know of it.
* Configured Renovate to update these daily (we'll see, maybe that's too frequent).
* If the "test" GitHub workflow passes, Renovate will auto-merge. Otherwise it will open a PR.
@intgr
Copy link
Contributor Author

intgr commented Sep 29, 2025

Let's give this a try.

@intgr intgr merged commit 7e06708 into typeddjango:master Sep 29, 2025
11 checks passed
@intgr intgr mentioned this pull request Sep 29, 2025
@intgr intgr deleted the renovate-lockFileMaintenance branch September 29, 2025 08:04
@intgr intgr self-assigned this Sep 29, 2025
@intgr
Copy link
Contributor Author

intgr commented Sep 29, 2025

I triggered a Renovate run manually (overriding schedule).

  • 1st attempt did not create a branch -- not sure why.
  • 2nd attempt succeeded as expected.

Commit on master: e719c4f

Let's see if it also successfully runs during daily schedule. I'm still not sure whether an explicit automergeSchedule is needed (https://docs.renovatebot.com/configuration-options/#automergeschedule)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant