V14: Obsolete runtime minification settings#16123
Merged
nikolajlauridsen merged 4 commits intov14/devfrom Apr 23, 2024
Merged
Conversation
elit0451
suggested changes
Apr 22, 2024
Contributor
elit0451
left a comment
elit0451
left a comment
There was a problem hiding this comment.
Looks good 💪
I believe we can also obsolete RuntimeMinificationCacheBuster 🙂
Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RuntimeMinificationSettingsare no longer required since runtime modification is not supported anymore.I've obsoleted the settings and not removed them entirely since this will make it show up as obsolete in the app settings.
I also haven't removed the config from DI either, just in case someone might have injected them, there's no reason to throw yet another error here, since we'll need to come back to this later and remove the config class later anyhow, we may as well wait with unregistering it until then.
Lastly I've obsoleted the
RuntimeMinificationValidatorand removed it from the list of checks, since it no longer makes sense.