Skip to content

V14: Obsolete runtime minification settings #16123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikolajlauridsen merged 4 commits into from
Apr 23, 2024
Merged

V14: Obsolete runtime minification settings #16123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85c4611
Obsolete RuntimeMinificationSettings
nikolajlauridsen Apr 22, 2024
8b78e84
Obsolete RuntimeMinificationValidator
nikolajlauridsen Apr 22, 2024
f9c08ef
Update src/Umbraco.Core/Constants-Configuration.cs
nikolajlauridsen Apr 23, 2024
2e242fc
Obsolete RuntimeMinificationCacheBuster
nikolajlauridsen Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Umbraco.Core/Configuration/Models/RuntimeMinificationCacheBuster.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
namespace Umbraco.Cms.Core.Configuration.Models;

[Obsolete("Runtime minification is no longer supported. Will be removed entirely in V16.")]
public enum RuntimeMinificationCacheBuster
{
Version,
Expand Down
1 change: 1 addition & 0 deletions src/Umbraco.Core/Configuration/Models/RuntimeMinificationSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace Umbraco.Cms.Core.Configuration.Models;

[Obsolete("Runtime minification is no longer supported. Will be removed entirely in V16.")]
[UmbracoOptions(Constants.Configuration.ConfigRuntimeMinification)]
public class RuntimeMinificationSettings
{
Expand Down
2 changes: 2 additions & 0 deletions src/Umbraco.Core/Constants-Configuration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ public static class Configuration
public const string ConfigRequestHandler = ConfigPrefix + "RequestHandler";
public const string ConfigRuntime = ConfigPrefix + "Runtime";
public const string ConfigRuntimeMode = ConfigRuntime + ":Mode";
[Obsolete("Runtime minification is no longer supported. Will be removed entirely in V16.")]
public const string ConfigRuntimeMinification = ConfigPrefix + "RuntimeMinification";
[Obsolete("Runtime minification is no longer supported. Will be removed entirely in V16.")]
public const string ConfigRuntimeMinificationVersion = ConfigRuntimeMinification + ":Version";
Comment thread
nikolajlauridsen marked this conversation as resolved.
public const string ConfigSecurity = ConfigPrefix + "Security";
public const string ConfigBasicAuth = ConfigPrefix + "BasicAuth";
Expand Down
1 change: 0 additions & 1 deletion src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.CoreServices.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ public static IUmbracoBuilder AddCoreInitialServices(this IUmbracoBuilder builde
.Add<JITOptimizerValidator>()
.Add<UmbracoApplicationUrlValidator>()
.Add<UseHttpsValidator>()
.Add<RuntimeMinificationValidator>()
.Add<ModelsBuilderModeValidator>();

// composers
Expand Down
1 change: 1 addition & 0 deletions src/Umbraco.Infrastructure/Runtime/RuntimeModeValidators/RuntimeMinificationValidator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ namespace Umbraco.Cms.Infrastructure.Runtime.RuntimeModeValidators;
/// Validates whether the runtime minification cache buster is not set to <see cref="RuntimeMinificationCacheBuster.Timestamp" /> when in production runtime mode.
/// </summary>
/// <seealso cref="Umbraco.Cms.Infrastructure.Runtime.RuntimeModeValidators.RuntimeModeProductionValidatorBase" />
[Obsolete("Runtime minification is no longer supported, so this is no longer relevant. Will be removed entirely in V16.")]
public class RuntimeMinificationValidator : RuntimeModeProductionValidatorBase
{
private readonly IOptionsMonitor<RuntimeMinificationSettings> _runtimeMinificationSettings;
Expand Down
1 change: 1 addition & 0 deletions tools/Umbraco.JsonSchema/UmbracoCmsSchema.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ public class UmbracoCmsDefinition

public required RichTextEditorSettings RichTextEditor { get; set; }

[Obsolete("Runtime minification is no longer supported. Will be removed entirely in V16.")]
public required RuntimeMinificationSettings RuntimeMinification { get; set; }

public required BasicAuthSettings BasicAuth { get; set; }
Expand Down