docs: update vite instructions#713
Merged
Merged
Conversation
If compiler options are only added to just tsconfig.json, module resolution fails for `@/lib/utils` during build.
sinh117801
added a commit
to sinh117801/shadcn-vue
that referenced
this pull request
Aug 17, 2024
If compiler options are only added to just tsconfig.json, module resolution fails for `@/lib/utils` during build. <!---☝️ PR title should follow conventional commits (https://conventionalcommits.org) --> ### 🔗 Linked issue <!-- Please ensure there is an open issue and mention its number as unovue#123 --> ### ❓ Type of change <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply. --> - [ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations) - [ ] 🐞 Bug fix (a non-breaking change that fixes an issue) - [x] 👌 Enhancement (improving an existing functionality like performance) - [ ] ✨ New feature (a non-breaking change that adds functionality) - [ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries) - [ ]⚠️ Breaking change (fix or feature that would cause existing functionality to change) ### 📚 Description <!-- Describe your changes in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If it resolves an open issue, please link to the issue here. For example "Resolves unovue#1337" --> ### 📸 Screenshots (if appropriate) <!-- Add screenshots to help explain the change. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have linked an issue or discussion. - [ ] I have updated the documentation accordingly.
sinh117801
added a commit
to sinh117801/shadcn-vue
that referenced
this pull request
Aug 17, 2024
If compiler options are only added to just tsconfig.json, module resolution fails for `@/lib/utils` during build. <!---☝️ PR title should follow conventional commits (https://conventionalcommits.org) --> <!-- Please ensure there is an open issue and mention its number as unovue#123 --> <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply. --> - [ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations) - [ ] 🐞 Bug fix (a non-breaking change that fixes an issue) - [x] 👌 Enhancement (improving an existing functionality like performance) - [ ] ✨ New feature (a non-breaking change that adds functionality) - [ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries) - [ ]⚠️ Breaking change (fix or feature that would cause existing functionality to change) The change is mean to allow event type to support `values: z.infer<typeof schema>`, not only `values: Record<string, any>` Resolves unovue#716 <!-- Add screenshots to help explain the change. --> <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have linked an issue or discussion. - [ ] I have updated the documentation accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
A pull request in Vite 5.3.0 introduced a change where the
tsconfig.jsonfile was separated into three files:tsconfig.json,tsconfig.app.json, andtsconfig.node.json:vitejs/vite#15913
The compilerOptions change also needs to be propagated to the
tsconfig.app.jsonotherwise the module resolution will fail upon build.📝 Checklist