[USH-1679] Rename the heading of the new post screen to 'Add New Post'#1482
Merged
MMwandigha merged 2 commits intodevelopmentfrom Nov 25, 2024
Merged
[USH-1679] Rename the heading of the new post screen to 'Add New Post'#1482MMwandigha merged 2 commits intodevelopmentfrom
MMwandigha merged 2 commits intodevelopmentfrom
Conversation
Ifycode
reviewed
Nov 25, 2024
| path: 'create/:type', | ||
| component: PostEditComponent, | ||
| data: { breadcrumb: 'Create Post' }, | ||
| data: { breadcrumb: 'Add New Post' }, |
Member
There was a problem hiding this comment.
We can just have another ticket to add translation for the breadcrumb text in this file, similar to how it's done in app routing module file @MMwandigha
Contributor
Author
There was a problem hiding this comment.
@Ifycode Oh yeah its true... I also thought of the same. I noticed that all the breadcrumb texts in the post-routing module haven't been translated yet. I shall create one
Contributor
Author
There was a problem hiding this comment.
Here's the associated PR for this:
#1483
tuxpiper
pushed a commit
that referenced
this pull request
Nov 26, 2024
Angamanga
pushed a commit
that referenced
this pull request
Nov 27, 2024
tuxpiper
pushed a commit
that referenced
this pull request
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renaming the heading of the new post breadcrumb to 'Add New Post'
Testing
Previously it was 'Create Post' but now it's 'Add New Post'