Skip to content

[USH-1679] Rename the heading of the new post screen to 'Add New Post' #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MMwandigha merged 2 commits into from
Nov 25, 2024
Merged

[USH-1679] Rename the heading of the new post screen to 'Add New Post' #1482

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c38b9b
Renaming the heading of the new post breadcrumb to 'Add New Post'
MMwandigha Nov 22, 2024
aa8aa07
Merge branch 'development' into USH-1679
MMwandigha Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web-mzima-client/src/app/post/post-routing.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const routes: Routes = [
{
path: 'create/:type',
component: PostEditComponent,
data: { breadcrumb: 'Create Post' },
data: { breadcrumb: 'Add New Post' },
Copy link
Member

@Ifycode Ifycode Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just have another ticket to add translation for the breadcrumb text in this file, similar to how it's done in app routing module file @MMwandigha

Copy link
Contributor Author

@MMwandigha MMwandigha Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ifycode Oh yeah its true... I also thought of the same. I noticed that all the breadcrumb texts in the post-routing module haven't been translated yet. I shall create one

Copy link
Member

@Ifycode Ifycode Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Copy link
Contributor Author

@MMwandigha MMwandigha Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the associated PR for this:
#1483

},
{
path: ':id/edit',
Expand Down