env: preserve non-UTF-8 environment variables and remove unwrap#9726
Merged
Conversation
ChrisDryden
changed the title
ChrisDryden
force-pushed
the
env-non-utf8
branch
from
December 19, 2025 21:09
be61953 to
5d4abd8
Compare
Merged
ChrisDryden
marked this pull request as ready for review
December 19, 2025 23:40
Collaborator
|
Looks good to me 👍 Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was based off of the discussion in the comments of #9702 where I found that there was a helper method that already existed called write_all_os that could be used.