Skip to content

Fix printenv non-UTF8#9728

Merged
sylvestre merged 2 commits into
uutils:mainfrom
RenjiSann:fix-printenv-utf8
Dec 22, 2025
Merged

Fix printenv non-UTF8#9728
sylvestre merged 2 commits into
uutils:mainfrom
RenjiSann:fix-printenv-utf8

Conversation

@RenjiSann

@RenjiSann RenjiSann commented Dec 19, 2025

Copy link
Copy Markdown
Collaborator

Fixes #9701

@RenjiSann
RenjiSann requested a review from sylvestre December 19, 2025 22:50
@sylvestre

Copy link
Copy Markdown
Contributor

this is the third pr for the same issue now :)
#9726
#9702

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@ChrisDryden

Copy link
Copy Markdown
Collaborator

#9726 is env and #9702 is printenv

@ChrisDryden

Copy link
Copy Markdown
Collaborator

Ideally you can take @RenjiSann 's implementation and @sylvestre 's tests, get the best of both PR's

@RenjiSann

Copy link
Copy Markdown
Collaborator Author

Replaced my test with @sylvestre's

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

@sylvestre

Copy link
Copy Markdown
Contributor

many jobs are failing :)

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/dd/no-allocate was skipped on 'main' but is now failing.
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@sylvestre
sylvestre merged commit 0bfbbc0 into uutils:main Dec 22, 2025
186 of 188 checks passed
@RenjiSann
RenjiSann deleted the fix-printenv-utf8 branch December 22, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

printenv skips environment variables with invalid UTF-8

3 participants