Skip to content

feat: set up infra, port button Lumo styles to CSS files #9245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 23, 2025

Conversation

vursen
Copy link
Contributor

@vursen vursen commented May 21, 2025

Description

  • Initialized folder structure for porting the Lumo theme to CSS files
  • Ported core Lumo styles to CSS files
  • Ported button and icon Lumo styles to CSS files
  • Updated the related visual tests to use CSS files
  • Added WTR plugins to support running visual tests with both JS-based and CSS-based Lumo versions
    • yarn test:lumo to run with JS-based Lumo
    • yarn test:lumo --ported to run with CSS-based Lumo
    • yarn start --theme=lumo to serve dev pages with JS-based Lumo
    • yarn start --theme=lumo --ported to serve dev pages with CSS-based Lumo
  • When using the JS-based version, the plugins automatically remove CSS imports or replace them with the appropriate JS imports
  • When using the CSS-based version, the plugins rewrite imports so that Lumo CSS files are applied on top of the new base styles

Part of #9082

Type of change

  • Feature

@vursen vursen force-pushed the v25_port-lumo-to-css-files_init branch from 1289308 to 833970e Compare May 21, 2025 12:46
@vursen vursen force-pushed the v25_port-lumo-to-css-files_init branch from 833970e to cf46386 Compare May 21, 2025 12:52
@vursen vursen requested a review from web-padawan May 21, 2025 13:21
Copy link

@vursen vursen merged commit bca6ef8 into main May 23, 2025
10 checks passed
@vursen vursen deleted the v25_port-lumo-to-css-files_init branch May 23, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants