-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix(isIBAN): improve IR locale
#2634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2634 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2566 2566
Branches 651 651
=========================================
Hits 2566 2566 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WikiRik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional sources I could find do indeed not mention a 0 at the start
WikiRik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, I was too quick. Could you add additional tests for valid IBANs that do not start with a 0?
|
of course, i added some initial tests for isIBAN (didn't have any tests before) |
test/validators/isIBAN.test.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this to the large validator file, where we already have the other isIBAN tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, so sorry didn't see it
done
fix(isIban): remove hard coded zero digit from iran iban
I have replaced the 0 digits in the IR iban pattern because there is no rule for such pattern. the only place i found where IR iban has been discussed is this wikipedia page
the reason for this adjustment is that i need to add Iran iban to fakerjs library which is testing the valid ibans with this library
Checklist