Skip to content

fix(isIBAN): improve IR locale #2634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubiin merged 3 commits into from
Nov 22, 2025
+2 −1
Merged

fix(isIBAN): improve IR locale #2634

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8dc7fbd
👌 IMPROVE: iran iban has no rule to include 0 digits
Nov 22, 2025
10ffc86
🧪 TEST: add missing isIBAN tests
Nov 22, 2025
c7c26c2
🧪 TEST: add missing isIBAN tests
Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/isIBAN.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const ibanRegexThroughCountryCode = {
IE: /^(IE[0-9]{2})[A-Z]{4}\d{14}$/,
IL: /^(IL[0-9]{2})\d{19}$/,
IQ: /^(IQ[0-9]{2})[A-Z]{4}\d{15}$/,
IR: /^(IR[0-9]{2})0\d{2}0\d{18}$/,
IR: /^(IR[0-9]{2})\d{22}$/,
IS: /^(IS[0-9]{2})\d{22}$/,
IT: /^(IT[0-9]{2})[A-Z]{1}\d{10}[A-Z0-9]{12}$/,
JO: /^(JO[0-9]{2})[A-Z]{4}\d{22}$/,
Expand Down
29 changes: 29 additions & 0 deletions test/validators/isIBAN.test.js
View file
Open in desktop
Copy link
Member

@WikiRik WikiRik Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this to the large validator file, where we already have the other isIBAN tests

Copy link
Contributor Author

@ds1371dani ds1371dani Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, so sorry didn't see it

done

Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import test from '../testFunctions';

describe('isIBAN', () => {
it('should validate IBANs', () => {
test({
validator: 'isIBAN',
valid: [
'IR576406610070915600106898',
],
invalid: [
// Invalid format/checksum
'IR545049154806779008008299',

// Invalid structure
'IR5750491548067790080082',

// Country code not in whitelist when specified
// Empty/null values
'',
' ',

// Random invalid strings
'not an iban',
'1234567890',
'ABCD1234567890',
],
});
});
});
Loading