Conversation
…_before_password_update Java test This test is redundant due to the active reconnect mechanism introduced in commit 68c6b3b. The reconnect mechanism efficiently handles passive reconnects and reestablishes connections in both CMD and CME modes, rendering this test unnecessary. Additionally, the test is flaky due to timing interdependencies between the updateConnectionPassword() implementation and the reconnect mechanism. Signed-off-by: ikolomi <ikolomin@amazon.com>
avifenesh
approved these changes
Jan 28, 2025
Yury-Fridlyand
added
java ☕
6 tasks
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is redundant due to the active reconnect mechanism introduced in commit 68c6b3b.
The reconnect mechanism efficiently handles passive reconnects and reestablishes connections in both CMD and CME modes, rendering this test unnecessary.
Additionally, the test is flaky due to timing interdependencies between the updateConnectionPassword() implementation and the reconnect mechanism.
Issue link
This Pull Request is linked to issue (URL): #2037
Checklist
Before submitting the PR make sure the following are checked:
[] CHANGELOG.md and documentation files are updated.