Skip to content

Java: Fix lpopCount null handling#3025

Merged
jamesx-improving merged 3 commits intomainfrom
java/jamesx-lpopcount-fix-null-handling
Jan 29, 2025
Merged

Java: Fix lpopCount null handling#3025
jamesx-improving merged 3 commits intomainfrom
java/jamesx-lpopcount-fix-null-handling

Conversation

@jamesx-improving
Copy link
Copy Markdown
Collaborator

@jamesx-improving jamesx-improving commented Jan 29, 2025

Issue link

This Pull Request is linked to issue (URL): #3024

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

Signed-off-by: James Xin <james.xin@improving.com>
Signed-off-by: James Xin <james.xin@improving.com>
Comment on lines -26 to -27
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collateral spotless damage from #3022

Copy link
Copy Markdown
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yury-Fridlyand Yury-Fridlyand added the java ☕ issues and fixes related to the java client label Jan 29, 2025
Signed-off-by: James Xin <james.xin@improving.com>
@jamesx-improving jamesx-improving merged commit 17a91b2 into main Jan 29, 2025
6 of 7 checks passed
@jamesx-improving jamesx-improving deleted the java/jamesx-lpopcount-fix-null-handling branch January 29, 2025 20:42
adarovadya pushed a commit to adarovadya/glide-for-redis that referenced this pull request Feb 3, 2025
Java: Fix lpopCount null handling
---------

Signed-off-by: James Xin <james.xin@improving.com>
liorsve pushed a commit to liorsve/valkey-glide that referenced this pull request Mar 30, 2025
Java: Fix lpopCount null handling
---------

Signed-off-by: James Xin <james.xin@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java ☕ issues and fixes related to the java client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants