Skip to content

feat: restyle Topics Page layout and components #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2025

Conversation

phiro56
Copy link
Contributor

@phiro56 phiro56 commented Apr 24, 2025

Description

Restyle Topics Page layout and components
- Update left-aside layout with reversed flex direction
- Style topic cards with new background and hover states
- Add rounded corners to main content area
- Implement responsive layout adjustments for mobile/desktop
- Update typography and spacing for topic descriptions

Dependencies

  • This PR depends on #242 (feat-ui-redesign-commands-page)
  • The changes in this PR should be reviewed and merged after the base PR is merged
Screenshot 2025-04-24 at 1 20 16 PM

phiro56 added 2 commits April 18, 2025 19:41
- Add left sidebar with command categories and alphabetical list
- Implement responsive design with mobile-first approach
- Add search functionality with real-time filtering
- Style command groups with improved readability
- Add no-results message for empty searches

Signed-off-by: Daniel Phillips <[email protected]>
- Update left-aside layout with reversed flex direction
- Style topic cards with new background and hover states
- Add rounded corners to main content area
- Implement responsive layout adjustments for mobile/desktop
- Update typography and spacing for topic descriptions

Signed-off-by: Daniel Phillips <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
@madolson madolson requested a review from Copilot May 9, 2025 23:29
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Topics Page layout and styling by restyling the layout components and topic cards for improved aesthetics and responsiveness.

  • Switched the layout from "right-aside" to "left-aside" to better align with the design requirements.
  • Updated the topics list markup from a div-based structure to semantic li elements with associated styling enhancements.
  • Refined typography and added new style rules for improved visual hierarchy.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
templates/docs.html Updated layout extension and refactored the topics list markup to use semantic
  • elements.
  • sass/_valkey.scss Added font-weight styling, introduced .topic-description styles, and cleaned up unused CSS selectors.
    Comments suppressed due to low confidence (2)

    templates/docs.html:49

    • The topic list markup has been refactored to use
    • elements, replacing the old .index-entry divs. Ensure that any related styles or scripts referencing .index-entry are updated or removed accordingly.
                <li>
    

    sass/_valkey.scss:949

    • The .index-entry selector has been removed from the block-menu styles. Confirm that this change is consistent with its usage in the templates and remove any related unused styles to maintain code clarity.
    .block-menu ul li {
    

    Copy link
    Member

    @madolson madolson left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    As always, didn't review any of the CSS, but verified it functionally works.

    @madolson madolson merged commit 4a8eaa4 into valkey-io:main May 9, 2025
    1 check passed
    zarkash-aws pushed a commit to zarkash-aws/valkey-io.github.io that referenced this pull request Jun 12, 2025
    ## Description
    Restyle Topics Page layout and components
        - Update left-aside layout with reversed flex direction
        - Style topic cards with new background and hover states
        - Add rounded corners to main content area
        - Implement responsive layout adjustments for mobile/desktop
        - Update typography and spacing for topic descriptions
    
    ### Dependencies
    - This PR depends on
    #[242](valkey-io#242)
    (feat-ui-redesign-commands-page)
    - The changes in this PR should be reviewed and merged after the base PR
    is merged
    
    <img width="1728" alt="Screenshot 2025-04-24 at 1 20 16 PM"
    src="https://github.com/user-attachments/assets/31875fcc-5331-41d7-85bf-5ac5523f096b"
    />
    
    ---------
    
    Signed-off-by: Daniel Phillips <[email protected]>
    Signed-off-by: Madelyn Olson <[email protected]>
    Co-authored-by: Madelyn Olson <[email protected]>
    Signed-off-by: Shai Zarka <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants