Skip to content

feat: restyle Topics Page layout and components #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2025
Merged

feat: restyle Topics Page layout and components #248

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf71924
feat: restyle Commands Page with new layout and search functionality
phiro56 Apr 19, 2025
921b2e2
feat: restyle Topics Page layout and components
phiro56 Apr 24, 2025
883c8f4
Merge branch 'main' into feat-ui-redesign-topics-page
madolson May 9, 2025
b3bf6cb
Update sass/_valkey.scss
madolson May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions sass/_valkey.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,16 +504,23 @@ p {
color: #000;
text-transform: uppercase;
cursor: pointer;
font-weight: 600;

&:hover {
background-color: #b9c6ff;
}
}
}
}
}
}
}

.topic-description {
display: block;
text-transform: none;
font-size: 90%;
}

.search-container {
display: flex;
align-items: center;
Expand Down Expand Up @@ -939,8 +946,7 @@ pre table {
margin-bottom: 0.5em;
}

.block-menu ul li,
.index-entry {
.block-menu ul li {
border: 1px solid $line;
border-radius: 3px;
a {
Expand Down
21 changes: 14 additions & 7 deletions templates/docs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
{% extends "right-aside.html" %}
{% extends "left-aside.html" %}

{% import "macros/docs.html" as docs %}

{% block subhead_content %}
<h1 class="page-title">Documentation by topic</h1>
<div class="styled-title">
<h1>Documentation by Topic</h1>
</div>
{% endblock subhead_content %}

{% block main_content %}
Expand Down Expand Up @@ -42,10 +44,15 @@ <h2>Alphabetical Index</h2>
{% set joined_list = list | join(sep=",") %}
{% set topic_list = load_data(literal= "[" ~ joined_list ~ "]", format="json") | sort(attribute="title") %}

{% for topic in topic_list %}
<div class="index-entry">
<a href="{{ topic.path }}">{{ topic.title }}</a> {{ topic.description | safe }} <br />
</div>
{% endfor %}
<ul class="topic-list">
{% for topic in topic_list %}
<li>
<a href="{{ topic.path }}">
{{ topic.title }}
<span class="topic-description">{{ topic.description | safe }}</span>
</a>
</li>
{% endfor %}
</ul>

{% endblock related_content %}