-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[megatron] fix: the NPU error that occurs after migrating from megatron worker to engine worker. #6135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[megatron] fix: the NPU error that occurs after migrating from megatron worker to engine worker. #6135
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
726f43b
[fix]: Fix the NPU error that occurs after migrating from megatron wo…
xiazhahe e47703a
[fix]: Fix the NPU error that occurs after migrating from megatron wo…
xiazhahe c7fe555
[megatron] fix: the NPU error that occurs after migrating from megatr…
xiazhahe 2c93588
[megatron] fix: the NPU error that occurs after migrating from megatr…
xiazhahe 693add4
[megatron] fix: the NPU error that occurs after migrating from megatr…
xiazhahe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
__init__method inMindspeedEngineWithValueHeadis redundant as it only callssuper().__init__with the exact same arguments as the base classMegatronEngineWithValueHead(and its ancestorMegatronEngine). In Python, this can be omitted to improve code clarity and maintainability.